[LV2] Qt5 plugin UIs and libsuil

Filipe Coelho falktx at gmail.com
Tue Mar 7 08:26:15 PST 2017


On 07.03.2017 17:16, Stefan Westerfeld wrote:
>     Hi!
>
> On Tue, Mar 07, 2017 at 03:37:35PM +0100, Filipe Coelho wrote:
>> On 06.03.2017 18:20, Stefan Westerfeld wrote:
>>> Ok, I've also put my suggestion on github:
>>>
>>> https://github.com/swesterfeld/suil/commit/ea400f7e70cd6ca81a03a919371f46779b737f71
>>>
>>> to make it a bit easier to test. Please, especially falkTX, could
>>> you test this? Would that work for everyone?
>> I don't have much time right now to test it, but looking through the
>> changes I recommend you to clean the patch first.
>> There's irrelevant code changes regarding spaces and qt=>qt5 rename,
>> which are not important right now for this issue.
>> Makes it harder to see what the changes really are.
> Ok, I committed a minimal/clean version of the changes here:
>
> https://github.com/swesterfeld/suil/commit/067f2d9c9ff06c883c8358b99542aaa0d6ad1a3a
>
>     Cu... Stefan

Looks ok to me, only a minor spaces vs tabs thing.

Do you know the minimum required version of qt5 for this?
I'm not sure if v5.0 had those APIs.


On a side note, I wonder if all this embedding will only work on X11...
At some point we need to see how to handle Wayland and/or Mir.



More information about the Devel mailing list