[LV2] [PATCH 1/5] add eg05-scope example plugin
David Robillard
d at drobilla.net
Wed Dec 25 10:02:03 PST 2013
On Tue, 2013-12-24 at 18:05 +0100, Robin Gareus wrote:
> On 12/24/2013 05:41 PM, David Robillard wrote:
>
> >> The ->size of the LV2_Atom is only about the payload and does not
> >> include the header itself in the count. The original version was
> >> correct. fix attached.
> >
> > Yes, you're right. The size calculation was correct but the casts were
> > not. It happened to work out that the data pointer ended up at the
> > right place anyway.
> >
>
> Ah. Good catch. Well now, there's good example code that is well
> documented, semantically correct and functional. No excuses anymore for
> getting this wrong :)
Assuming people actually read the documentation which is optimistic at
best, but at least that's their fault :)
I have bookified the examploscope documentation. Still tinkering with
how to make this style of documentation work well (or wondering if it's
really the way to go), but this seems okay:
http://lv2plug.in/book/#_simple_oscilloscope
--
dr
More information about the Devel
mailing list