[LV2] [PATCH 1/5] add eg05-scope example plugin
robin at gareus.org
Fri Dec 20 15:40:14 PST 2013
On 12/15/2013 10:19 PM, David Robillard wrote:
> On Sun, 2013-12-15 at 16:00 -0500, David Robillard wrote:
>> On Mon, 2013-12-09 at 20:41 +0100, Robin Gareus wrote:
>>> plugins/eg05-scope.lv2/examploscope_ui.c | 629 ++++++++++++++++++++++++++++
>> There seems to be broken atom logic in this code:
> I have fixed this and cleaned up the associated code to be clearer.
great job (except for the issue mentioned in last mail). It reads indeed
much nicer. Thanks.
> Also went through all the code and fixed it for stylistic consistency
> with the rest of LV2. Some of it really went through the wringer, so
> you might want to double check that it's all still sane to your eyes. I
> haven't tested the UI state preserving stuff.
state save/re-load works.
> One thing worth mentioning, which I added as a comment to explain for
> others as well: there is a strong URI naming convention for things:
> types are capitalized, other things like properties are not. So,
> objects with types like "ui-state" shouldn't happen.
Interesting. I never thought about capitalization. Pretty much
everything is always lower-case here. I very much prefer underscores or
dashes to CamelCase.
> Things in the
> distribution must adhere to this convention (which is pretty much
> universal even outside LV2),
> but you really should in your own code as well.
More information about the Devel